Update highlight popup text on mobile #2386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CORE-672]
RoyEJohnson
commented
Jan 14, 2025
| @@ -220,7 +220,7 @@ | |||
| "i18n:toolbar:highlights:popup:heading": "Moje notatki i zakreślenia", | |||
| "i18n:toolbar:highlights:popup:heading:no-highlights": "Brak wyników", | |||
| "i18n:toolbar:highlights:popup:heading:no-highlights-tip": "Wybierz inny <strong>rozdział albo kolor</strong>, żeby zobaczyć inne wyniki.", | |||
| "i18n:toolbar:highlights:popup:help-info": "Potrzebujesz pomocy? Przejdź do <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Support Center</a>", | |||
| "i18n:toolbar:highlights:popup:help-info": "Notatek i wyróżnień nie można edytować na urządzeniach mobilnych. <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Przeczytaj więcej</a>", | |||
There was a problem hiding this comment.
@ewaforman Please check this translation of "Notes and highlights cannot be edited on mobile devices. Read more"
RoyEJohnson
commented
Jan 14, 2025
| @@ -220,7 +220,7 @@ | |||
| "i18n:toolbar:highlights:popup:heading": "Mis textos resaltados y notas", | |||
| "i18n:toolbar:highlights:popup:heading:no-highlights": "No hay resultados.", | |||
| "i18n:toolbar:highlights:popup:heading:no-highlights-tip": "Intente seleccionar diferentes <strong> filtros de color o de capítulo </strong> para ver diferentes resultados.", | |||
| "i18n:toolbar:highlights:popup:help-info": "¿Necesita ayuda? Visite <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Support Center</a>", | |||
| "i18n:toolbar:highlights:popup:help-info": "Las notas y los resaltados no se pueden editar en dispositivos móviles. <a data-testid='support-link' data-analytics-label='support-link' target=\"_blank\" href=\"https://help.openstax.org/s/article/Using-the-highlighting-and-note-taking-feature-on-mobile-or-tablet?search=highlighting\">Leer más</a>", | |||
There was a problem hiding this comment.
@bethshook Please check this translation of "Notes and highlights cannot be edited on mobile devices. Read more"
There was a problem hiding this comment.
Slight change: Las notas y los textos resaltados
jivey
requested changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-672
Need review of translations Spanish (@bethshook ) and Polish (@ewaforman)