This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
explicitly exclude the version that breaks app-factory startup model #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that i discussed various places to put this pin w/ Scott. Since this play is where gunicorn is currently installed, decided not to bury it in a requirements file somewhere in each environment. |
meeragovindaraju
added this to the Release 2019-12-04; Code Freeze 2019-11-22 milestone
DarkPrinceFrost
approved these changes
Jan 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent version of gunicorn breaks the app-factory model we're using to launch the validator.
Issue here: benoitc/gunicorn#2159
Fix has been commited upstream: benoitc/gunicorn@19cb68f#diff-5832adf374920d75d4bf48e546367f53R67
So presumably, next release will work. (Our use-case is explicitly included in the tests in that commit)
This PR changes the gunicorn install to not install the one, broken, version.