Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Photo linking #6196

Open
famo opened this issue Apr 17, 2019 · 7 comments
Open

Support for Photo linking #6196

famo opened this issue Apr 17, 2019 · 7 comments
Labels
streetlevel An issue with streetlevel photos

Comments

@famo
Copy link

famo commented Apr 17, 2019

It would be nice if iD could support Photo linking:
https://wiki.openstreetmap.org/wiki/Photo_linking

However, it shouldn't show the image directly in the editor, because this can introduce unwanted data traffic (and the image would probably be to small anyways).

Rather the editor should provide a link with the complete URL, which upon clicking would open in a new tab.

Ideally this link is directly available in the fields section or should be visible after clicking the i next to the tag.

@bhousel
Copy link
Member

bhousel commented Apr 17, 2019

Thanks @fmao - have you tried iD's Mapillary / Streetside / OpenStreetCam integrations?

@famo
Copy link
Author

famo commented Apr 17, 2019

No, so far I encountered only links which referred to wikimedia commons...

@Bibi56
Copy link

Bibi56 commented Dec 5, 2019

I'd suggest this for OpenStreetCam and Bing Streetside too but people don't seem to be linking those with tags right now.
(from @quincylvania in #7064)

"right now" as the coverage is not as good and as the editors were not as tuned for those sources. If you improve the usability, you'll be rewarded by the growth of usage.

@quincylvania
Copy link
Collaborator

"right now" as the coverage is not as good and as the editors were not as tuned for those sources. If you improve the usability, you'll be rewarded by the growth of usage.

@Bibi56 I agree. When we add photo linking I don't see why it wouldn't work the same way for all four photo overlay sources.

@quincylvania quincylvania added the streetlevel An issue with streetlevel photos label Dec 5, 2019
@quincylvania
Copy link
Collaborator

Re-reading this issue, I see it just specifies the sort of field functionality added for #7064. I've been considering "adding support for photo linking" to involve the actual linking of images from iD's street level viewer to OSM features with a UI element, so I'd say let's keep this open until we add that.

@tordans
Copy link
Collaborator

tordans commented Dec 27, 2020

I've been considering "adding support for photo linking" to involve the actual linking of images from iD's street level viewer to OSM features with a UI element, so I'd say let's keep this open until we add that.

I talked to @cbeddow about this by mail and wanted to add a few thoughts.

Possible usecases:

a. Case: OSM object selected, does not have a mapillary-key, street level viewer shows image
=> Button on street level viewer to add the current image to the object as mapillary=

add-tag-when-no-key Kopie-2

b. Case: OSM object selected, mapillary-key field was added manually via "add field", street level viewer shows image
=> Button on the key-form-element to copy the ID

copy-id-when-key-present Kopie-1

c. Case: OSM object selected, mapillary-key is present
=> Button to reveal the current image in the street level viewer

reveal Kopie-1

Further cases would be, to handle situations where a key is already present. In this case, (a) + (b) could just overwrite the existing key; but maybe with a confirmation first?

@cbeddow
Copy link
Contributor

cbeddow commented Dec 28, 2020

I'm really supportive of what Tobias has suggested. Another idea is to have the button inside the viewer window itself, maybe in the corner, with "Tag Currently Selected Object w/Mapillary image ID".

As a note, it's preferred to use mapillary:image=* and not just mapillary=*.

laigyu added a commit to laigyu/iD that referenced this issue Dec 20, 2023
more info see openstreetmap#6196 (comment)
I do the b. (set button) and c. (view button)
order: click OSM object -> click mapillary layer will close the OSM input field. need to do in reverse order
laigyu added a commit to laigyu/iD that referenced this issue Dec 27, 2023
It is the a. part in openstreetmap#6196 (comment)

still need to add button disabled logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
streetlevel An issue with streetlevel photos
Projects
None yet
Development

No branches or pull requests

6 participants