-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Photo linking #6196
Comments
Thanks @fmao - have you tried iD's Mapillary / Streetside / OpenStreetCam integrations? |
No, so far I encountered only links which referred to wikimedia commons... |
"right now" as the coverage is not as good and as the editors were not as tuned for those sources. If you improve the usability, you'll be rewarded by the growth of usage. |
@Bibi56 I agree. When we add photo linking I don't see why it wouldn't work the same way for all four photo overlay sources. |
Re-reading this issue, I see it just specifies the sort of field functionality added for #7064. I've been considering "adding support for photo linking" to involve the actual linking of images from iD's street level viewer to OSM features with a UI element, so I'd say let's keep this open until we add that. |
I talked to @cbeddow about this by mail and wanted to add a few thoughts. Possible usecases: a. Case: OSM object selected, does not have a mapillary-key, street level viewer shows image b. Case: OSM object selected, mapillary-key field was added manually via "add field", street level viewer shows image c. Case: OSM object selected, mapillary-key is present Further cases would be, to handle situations where a key is already present. In this case, (a) + (b) could just overwrite the existing key; but maybe with a confirmation first? |
I'm really supportive of what Tobias has suggested. Another idea is to have the button inside the viewer window itself, maybe in the corner, with "Tag Currently Selected Object w/Mapillary image ID". As a note, it's preferred to use |
more info see openstreetmap#6196 (comment) I do the b. (set button) and c. (view button) order: click OSM object -> click mapillary layer will close the OSM input field. need to do in reverse order
It is the a. part in openstreetmap#6196 (comment) still need to add button disabled logic
It would be nice if iD could support Photo linking:
https://wiki.openstreetmap.org/wiki/Photo_linking
However, it shouldn't show the image directly in the editor, because this can introduce unwanted data traffic (and the image would probably be to small anyways).
Rather the editor should provide a link with the complete URL, which upon clicking would open in a new tab.
Ideally this link is directly available in the fields section or should be visible after clicking the
i
next to the tag.The text was updated successfully, but these errors were encountered: