libmultipath: fix 'show paths format' failure #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent 'multipathd show paths format "%c"' from failing on orphan paths. For orphan paths the checker class isn't set, which caused snprint_path_checker() to fail which in turn caused 'show paths format' to fail when the format string contained "%c".
|
On our Kubernetes nodes, the HPE CSI driver sometimes failed to attach persistent volumes with an "unable to get scsi slaves for device..." message. |
|
Thanks, this looks ok. But although there've been a few exceptions lately, we still use a mailing-list based workflow. Please post your patch to dm-devel AT redhat.com, cc mwilck AT suse.com and bmarzins AT redhat.com. |
|
Thanks, I've posted the patch to dm-devel and am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent 'multipathd show paths format "%c"' from failing on orphan paths. For orphan paths the checker class isn't set, which caused snprint_path_checker() to fail which in turn caused 'show paths format' to fail when the format string contained "%c".