Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multipath.conf.5: fix the description of prio_args for path_latency prio #87

Conversation

Cav4ever
Copy link

@Cav4ever Cav4ever commented Jun 12, 2024

This aligns the description of prio_args for path_latency prio and the actual code.

I've already sent this patch to the mailing list for multipath-tools([email protected]).
https://lore.kernel.org/dm-devel/[email protected]/

This aligns the description of prio_args for path_latency prio and
the actual code.

Signed-off-by: Kou Wenqi <[email protected]>
@Cav4ever
Copy link
Author

Cav4ever commented Jun 12, 2024

In the code, io_num is of type int in the range [20, 200] and base_num is of type double in the range [1.1, 10].

// libmultipath/prioritizers/path_latency.c
#define MAX_IO_NUM		200
#define MIN_IO_NUM		20
#define DEF_IO_NUM		100

#define MAX_BASE_NUM		10
#define MIN_BASE_NUM		1.1

// libmultipath/prioritizers/path_latency.c
int check_args_valid(int io_num, double base_num)

The multipath.conf man page states that io_num is in the range [2,200] and base_num is an int in the range [2,10].
Referring to the man page to configure io_num to 10 and base_num to 10, io_num is indeed out of the range of [20, 200].

@mwilck
Copy link
Collaborator

mwilck commented Jun 12, 2024

LGTM, thanks.

I also ack'd this on dm-devel (assuming you are the same person that created this post).

I'd rather postpone it until #85 is merged, though.

@Cav4ever
Copy link
Author

Cav4ever commented Jun 12, 2024

I also ack'd this on dm-devel (assuming you are the same person that created this post).

Yes, it's me. Thanks.

@mwilck mwilck mentioned this pull request Aug 15, 2024
@cvaroqui cvaroqui closed this in #94 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants