Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WAF certificate name validation #1116

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Add WAF certificate name validation #1116

merged 1 commit into from
Jun 10, 2021

Conversation

outcatcher
Copy link
Contributor

Summary of the Pull Request

Add validation of WAF certificate name

Fix #1095

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccWafCertificateV1_basic
--- PASS: TestAccWafCertificateV1_basic (17.66s)
=== RUN   TestAccWafCertificateV1_validation
--- PASS: TestAccWafCertificateV1_validation (0.16s)
PASS

Process finished with the exit code 0

@outcatcher outcatcher requested review from a team, lego963 and anton-sidelnikov and removed request for a team June 10, 2021 10:12
@outcatcher outcatcher added the gate Merge PR label Jun 10, 2021
@otc-zuul
Copy link

otc-zuul bot commented Jun 10, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 8662619 into devel Jun 10, 2021
@otc-zuul otc-zuul bot deleted the waf/cert-name-validation branch June 10, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lego963 lego963 lego963 approved these changes

@otc-zuul otc-zuul[bot] otc-zuul[bot] approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
dependencies gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WAF] missing certificate name validation
3 participants
@outcatcher @lego963 @anton-sidelnikov