Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not loading cloud config #828

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Fix not loading cloud config #828

merged 1 commit into from
Feb 5, 2021

Conversation

outcatcher
Copy link
Contributor

@outcatcher outcatcher commented Feb 5, 2021 •
edited
Loading

Summary of the Pull Request

Fix cloud configuration loaded by name defined in provider config

Fix #826

PR Checklist

Acceptance Steps Performed

=== RUN   TestLoadAndValidate_cloud
--- PASS: TestLoadAndValidate_cloud (0.00s)
PASS

Process finished with exit code 0

@outcatcher outcatcher requested review from a team, lego963 and anton-sidelnikov and removed request for a team February 5, 2021 08:32
lego963
lego963 previously approved these changes Feb 5, 2021
View reviewed changes
@outcatcher

This comment has been minimized.

Sign in to view
otc-zuul[bot]
otc-zuul bot previously approved these changes Feb 5, 2021
View reviewed changes
@outcatcher outcatcher added the gate Merge PR label Feb 5, 2021
@otc-zuul
Copy link

otc-zuul bot commented Feb 5, 2021

Build failed.

@outcatcher

This comment has been minimized.

Sign in to view
@outcatcher
Fix not loading cloud config
2aa54d5 
Fix cloud configuration loaded by name defined in provider config
@outcatcher

This comment has been minimized.

Sign in to view
@outcatcher outcatcher added gate Merge PR and removed gate Merge PR labels Feb 5, 2021
@otc-zuul
Copy link

otc-zuul bot commented Feb 5, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 3d0c619 into master Feb 5, 2021
@otc-zuul otc-zuul bot deleted the fix/cloud-loading branch February 5, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lego963 lego963 lego963 approved these changes

@otc-zuul otc-zuul[bot] otc-zuul[bot] approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
dependencies gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

project name/id not working in provider versions 1.22.6 & 1.22.7
3 participants
@outcatcher @lego963 @anton-sidelnikov