Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vpc_eip_v1] refactoring tags #830

Merged
merged 4 commits into from
Feb 8, 2021
Merged

[vpc_eip_v1] refactoring tags #830

merged 4 commits into from
Feb 8, 2021

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Feb 8, 2021 •
edited
Loading

Summary of the Pull Request

Update gophersdk dependency
Refactoring vpc_eip_v1
Resolves: #557

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccVpcV1EIP_basic
--- PASS: TestAccVpcV1EIP_basic (54.78s)
=== RUN   TestAccVpcV1EIP_timeout
--- PASS: TestAccVpcV1EIP_timeout (31.20s)
PASS

Process finished with exit code 0

=== RUN   TestAccOTCVpcV1_basic
--- PASS: TestAccOTCVpcV1_basic (36.62s)
=== RUN   TestAccOTCVpcV1_update
--- PASS: TestAccOTCVpcV1_update (52.43s)
=== RUN   TestAccOTCVpcV1_timeout
--- PASS: TestAccOTCVpcV1_timeout (34.28s)
PASS

Process finished with exit code 0

=== RUN   TestAccOTCVpcSubnetV1_basic
--- PASS: TestAccOTCVpcSubnetV1_basic (77.02s)
=== RUN   TestAccOTCVpcSubnetV1_timeout
--- PASS: TestAccOTCVpcSubnetV1_timeout (57.29s)
PASS

Process finished with exit code 0

=== RUN   TestAccDNSV2RecordSet_basic
--- PASS: TestAccDNSV2RecordSet_basic (74.93s)
=== RUN   TestAccDNSV2RecordSet_readTTL
--- PASS: TestAccDNSV2RecordSet_readTTL (43.66s)
=== RUN   TestAccDNSV2RecordSet_timeout
--- PASS: TestAccDNSV2RecordSet_timeout (44.06s)
=== RUN   TestAccDNSV2RecordSet_shared
--- PASS: TestAccDNSV2RecordSet_shared (76.51s)
PASS

Process finished with exit code 0

=== RUN   TestAccDNSV2Zone_basic
--- PASS: TestAccDNSV2Zone_basic (44.72s)
=== RUN   TestAccDNSV2Zone_private
--- PASS: TestAccDNSV2Zone_private (26.58s)
=== RUN   TestAccDNSV2Zone_readTTL
--- PASS: TestAccDNSV2Zone_readTTL (26.23s)
=== RUN   TestAccDNSV2Zone_timeout
--- PASS: TestAccDNSV2Zone_timeout (25.77s)
PASS

Process finished with exit code 0

=== RUN   TestAccCCENodesV3_basic
--- PASS: TestAccCCENodesV3_basic (795.89s)
=== RUN   TestAccCCENodesV3_timeout
--- PASS: TestAccCCENodesV3_timeout (762.17s)
=== RUN   TestAccCCENodesV3_os
--- PASS: TestAccCCENodesV3_os (724.72s)
=== RUN   TestAccCCENodesV3_bandWidthResize
--- PASS: TestAccCCENodesV3_bandWidthResize (900.06s)
=== RUN   TestAccCCENodesV3_eipIds
--- PASS: TestAccCCENodesV3_eipIds (745.91s)
=== RUN   TestAccCCENodesV3_ipSetNull
--- PASS: TestAccCCENodesV3_ipSetNull (799.01s)
=== RUN   TestAccCCENodesV3_ipCreate
--- PASS: TestAccCCENodesV3_ipCreate (763.46s)
=== RUN   TestAccCCENodesV3_ipWithExtendedParameters
--- PASS: TestAccCCENodesV3_ipWithExtendedParameters (720.78s)
=== RUN   TestAccCCENodesV3_ipNulls
--- PASS: TestAccCCENodesV3_ipNulls (763.24s)
PASS

Process finished with exit code 0

@lego963
Minor changes
5681ed6 
Refactoring vpc_eip_v1

Update gophercloudsdk
@lego963
go mod tidy
8e9bbd1
@lego963
Update doc
d04ead6
@lego963 lego963 requested review from a team, outcatcher and anton-sidelnikov and removed request for a team February 8, 2021 08:30
outcatcher
outcatcher suggested changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@outcatcher outcatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run acceptance tests for all affected functionality

@lego963 lego963 added gate Merge PR and removed gate Merge PR labels Feb 8, 2021
@lego963 lego963 added the gate Merge PR label Feb 8, 2021
@otc-zuul
Copy link

otc-zuul bot commented Feb 8, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 11d2cb1 into master Feb 8, 2021
@otc-zuul otc-zuul bot deleted the tags-vpc-eip branch February 8, 2021 11:54
This was referenced Feb 8, 2021
Closed
Merged
otc-zuul bot pushed a commit that referenced this pull request Feb 8, 2021
@lego963
[dns_ptrrecord_v2] fix issues with tags (#832)
63138ea 
[dns_ptrrecord_v2] fix issues with tags

Summary of the Pull Request
Fix issue with tag when resource config is changed
PR Checklist

 Refers to: #830
 Tests added/passed.

Acceptance Steps Performed
=== RUN   TestAccDNSV2PtrRecord_basic
--- PASS: TestAccDNSV2PtrRecord_basic (66.56s)
PASS

Process finished with exit code 0

Reviewed-by: Anton Sidelnikov <None>
Reviewed-by: Anton Kachurin <[email protected]>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@otc-zuul otc-zuul[bot] otc-zuul[bot] approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
dependencies documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Set name and tags for floating IP
3 participants
@lego963 @outcatcher @anton-sidelnikov