-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase stacklevel in LoggingMachine log calls #2476
fix: increase stacklevel in LoggingMachine log calls #2476
Conversation
Thank you for this contribution! |
ref: python/cpython#97941 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz fix ruff formatter issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls accept changes and we can move forward with approval
Co-authored-by: Roman <[email protected]>
Co-authored-by: Roman <[email protected]>
Bug
Fixes #2449
Description of the Change
"loggingmachine.py" is printed in logs because LoggingMachine does not unstack it's internal calls to wrapped logger
Alternate Designs
Adding LoggerAdapter
Possible Drawbacks
None
Verification Process
Ran unittests.
Checked logs are formatted correctly.
Release Notes