set_weights: prevent exception when not registered #2555
Closed
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heeres
commented
Dec 21, 2024
heeres
commented
- The return value of get_uid_for_hotkey_on_subnet was not checked. If the hotkey is not registered, this call will return None, resulting in an exception later on.
- The return value of get_uid_for_hotkey_on_subnet was not checked. If the hotkey is not registered, this call will return None, resulting in an exception later on.
heeres
force-pushed
the
set_weight_reg_fix
branch
from
ae8452c to
4417284
Compare
|
Hey @heeres, Thank you for your contribution! Can you please update the branch so we can merge this in. |
|
Seems to be fixed by commit 3497cd6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.