Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisations and tests for Async Sync Subtensor #2569

Conversation

thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Jan 7, 2025

Fixes the tests in this branch, as well as adds some code optimisations.

Main features:

  • Using a single event loop
  • Not double-initalising AsyncSubstrateInterface
  • Using the mock property/arg of Subtensor/AsyncSubtensor properly
  • Reducing LOC as it relates to execute_coroutine within Subtensor
  • All tests (Integration, Unit, E2E) passing.

@thewhaleking thewhaleking force-pushed the feat/thewhaleking/improve-substrate branch from 25dcb0e to bd2f3c7 Compare January 7, 2025 19:02
@thewhaleking thewhaleking changed the title [WIP] Optimisations and tests for Async Sync Subtensor Optimisations and tests for Async Sync Subtensor Jan 7, 2025
@thewhaleking thewhaleking marked this pull request as ready for review January 7, 2025 23:33
@thewhaleking thewhaleking requested a review from a team January 7, 2025 23:34
@thewhaleking thewhaleking merged commit fbc6a83 into feat/roman/async-to-sync-via-wrapper Jan 8, 2025
15 checks passed
@thewhaleking thewhaleking deleted the feat/thewhaleking/improve-substrate branch January 8, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants