Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling errors #2586

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Conversation

Dimitrolito
Copy link

  • Fixed spelling mistake: "commited" to "committed" in commit_reveal.py.
  • Corrected the typo "tyep" to "type" in networking.py.

thewhaleking
thewhaleking previously approved these changes Jan 18, 2025
@thewhaleking thewhaleking changed the base branch from master to staging January 18, 2025 18:25
@thewhaleking thewhaleking dismissed their stale review January 18, 2025 18:25

The base branch was changed.

Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will merge after back-merging master to staging. In the future, please base all PRs off of staging.

Copy link
Contributor

@roman-opentensor roman-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please remove changes for unrelated files.

CHANGELOG.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove this file changes from PR

Copy link
Contributor

@thewhaleking thewhaleking Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as a result of the base branch changing. When we backmerged master, this went away.

VERSION Outdated Show resolved Hide resolved
@thewhaleking thewhaleking merged commit 94749d2 into opentensor:staging Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants