Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for list type inputs #103

Merged
merged 17 commits into from
Sep 23, 2024

Conversation

ibraheem-opentensor
Copy link
Contributor

@ibraheem-opentensor ibraheem-opentensor commented Sep 20, 2024

  • Users can now use --netuid 1,2,3,4 or --netuid "1, 2, 3, 4" instead of -n 1 -n 2 -n 3
  • Extended to netuids, weights, salt
  • Explicitly ask for hotkey name when creating a new hotkey
  • Support for both ss58 and wallet name in include,exclude hotkeys
  • list convention extendted to include and exclude hotkeys
  • Exit early in-case no subnets found in sudo set (which is why added return in _run command)
  • Fixes balance conversion in stake multiple

Watchmaker and others added 3 commits September 20, 2024 17:24
* Init commit

* Fixes table

* Working

* Adds back Hotkey

* Adds separation in overview

* WIP: Senate

* Finishes senate e2e

* Fixes tests
@@ -138,7 +138,7 @@ class Options:
show_default=False,
)
netuids = typer.Option(
[],
None,
"--netuids",
"-n",
help="Set the netuid(s) to filter by. Separate multiple netuids with a space, for example: `0 1 2`.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updated

@@ -149,7 +149,7 @@ class Options:
prompt=True,
)
weights = typer.Option(
[],
None,
"--weights",
"-w",
help="Weights for the specified UIDs, e.g. `-w 0.2 -w 0.4 -w 0.1 ...` Must correspond to the order of the UIDs.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updated

thewhaleking
thewhaleking previously approved these changes Sep 21, 2024
@thewhaleking
Copy link
Contributor

Approved, but do we want to do the same thing for --include-hotkeys, --exclude-hotkeys, and the like?

thewhaleking
thewhaleking previously approved these changes Sep 23, 2024
@ibraheem-opentensor
Copy link
Contributor Author

Approved, but do we want to do the same thing for --include-hotkeys, --exclude-hotkeys, and the like?

Great call - let me implement this there too; then we can merge in one go

thewhaleking and others added 5 commits September 23, 2024 12:25
* Give user the UID immediately after root registration.

* Subnet register
* Give user the UID immediately after root registration.

* Only check size of PGP fingerprint if it's actually set.
* Enhances max_stake and column change in list-delegates

* Ruff

* Ruff

---------

Co-authored-by: Benjamin Himes <[email protected]>
@ibraheem-opentensor ibraheem-opentensor merged commit 9852acf into main Sep 23, 2024
3 checks passed
@ibraheem-opentensor ibraheem-opentensor deleted the enhancement/abe/adds-support-lists branch September 25, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants