Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for ss58 addresses in wallet balance #171

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Adds support for ss58 addresses in wallet balance #171

merged 4 commits into from
Oct 9, 2024

Conversation

ibraheem-opentensor
Copy link
Contributor

  • This is entirely optional. Since majority people dont pass ss58 addresses, we are not explicitly asking for it.
  • Add-on to support the EVM push

thewhaleking
thewhaleking approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea, and I like this. Should we allow for more than one though?

@ibraheem-opentensor ibraheem-opentensor merged commit f044317 into staging Oct 9, 2024
1 check passed
@ibraheem-opentensor ibraheem-opentensor deleted the feat/support-ss58-wallet-balances branch October 9, 2024 19:45
@ibraheem-opentensor ibraheem-opentensor mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewhaleking thewhaleking thewhaleking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibraheem-opentensor @thewhaleking