Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for rpc request error handler, root list default empty values, prev delegate fetching #175

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Oct 10, 2024

In #131 we changed the request id of "rpc_request" to a randomised ID. Unfortunately, I neglected to update the error handler to reflect this change.

root list would fail because of None values in an ugly way. Use default empty values (such as []) for returns now.

Fixes root list-delegates running on non-archive nodes (such as local chain) by attempting to grab at a -1200 block offset first, then -200, then defaulting to None if previous delegates cannot be fetched.

@thewhaleking thewhaleking changed the title Fix for randomised rpc request error handler Fixes for rpc request error handler, default empty values, prev delegate fetching Oct 10, 2024
@thewhaleking thewhaleking changed the title Fixes for rpc request error handler, default empty values, prev delegate fetching Fixes for rpc request error handler, root list default empty values, prev delegate fetching Oct 10, 2024
@thewhaleking thewhaleking merged commit f36deb0 into staging Oct 10, 2024
1 check passed
@thewhaleking thewhaleking deleted the fix/thewhaleking/randomised-rpc-request branch October 10, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants