Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle incorrect password #187

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Better handle incorrect password #187

merged 1 commit into from
Oct 15, 2024

Conversation

thewhaleking
Copy link
Contributor

Fixes #186

This handles the general shutdowns better, in addition to giving a verbose output for incorrect passwords.

@thewhaleking thewhaleking added the bug Something isn't working label Oct 15, 2024
@thewhaleking thewhaleking linked an issue Oct 15, 2024 that may be closed by this pull request
Attribute Error for incorrect password #186
Closed
@thewhaleking thewhaleking requested review from a team and ibraheem-opentensor October 15, 2024 15:07
camfairchild
camfairchild approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should open an issue for raising a PasswordError from the btwallet package

@thewhaleking thewhaleking merged commit 885d1fd into staging Oct 15, 2024
1 check passed
@thewhaleking thewhaleking deleted the fix/thewhaleking/better-handle-incorrect-pw branch October 15, 2024 15:53
@roman-opentensor roman-opentensor mentioned this pull request Oct 17, 2024
Closed
12 tasks
@ibraheem-opentensor ibraheem-opentensor mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camfairchild camfairchild camfairchild approved these changes

@ibraheem-opentensor ibraheem-opentensor Awaiting requested review from ibraheem-opentensor

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Attribute Error for incorrect password
2 participants
@thewhaleking @camfairchild