-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhances tests according to changes #45
Merged
ibraheem-opentensor
merged 10 commits into
main
from
tests/adds-input-and-remove-wallets
Sep 4, 2024
Merged
Enhances tests according to changes #45
ibraheem-opentensor
merged 10 commits into
main
from
tests/adds-input-and-remove-wallets
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ibraheem-opentensor
commented
Sep 3, 2024
•
edited
Loading
edited
- Adds prompt support to tests
- Adds remove_wallet which removes the created wallet_dir after tests are done
- Fixes tests based on new UI
- Prints information as the test runs
- Outputs each command as it is invoked -> Easier to diagnose problems
thewhaleking
previously approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, lgtm. Though I would like to see the remove_wallet functionality executed regardless of test pass/fail. If it's not easily doable, we can come back to it later.
@thewhaleking Great idea! Implemented |
thewhaleking
approved these changes
Sep 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.