Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhances tests according to changes #45

Merged
merged 10 commits into from
Sep 4, 2024

Conversation

ibraheem-opentensor
Copy link
Contributor

@ibraheem-opentensor ibraheem-opentensor commented Sep 3, 2024

  • Adds prompt support to tests
  • Adds remove_wallet which removes the created wallet_dir after tests are done
  • Fixes tests based on new UI
  • Prints information as the test runs
  • Outputs each command as it is invoked -> Easier to diagnose problems

thewhaleking
thewhaleking previously approved these changes Sep 4, 2024
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, lgtm. Though I would like to see the remove_wallet functionality executed regardless of test pass/fail. If it's not easily doable, we can come back to it later.

@ibraheem-opentensor
Copy link
Contributor Author

@thewhaleking Great idea! Implemented

@ibraheem-opentensor ibraheem-opentensor merged commit 94e1a8c into main Sep 4, 2024
2 of 3 checks passed
@thewhaleking thewhaleking deleted the tests/adds-input-and-remove-wallets branch September 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants