Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests + fixes #92

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Conversation

ibraheem-opentensor
Copy link
Contributor

@ibraheem-opentensor ibraheem-opentensor commented Sep 19, 2024

  • Adds --no-use-hotkey for set_id
  • Fixes stake show prompting in-case --all used
  • Enhances prompt text for stake add/remove
  • Adds validate_coldkey_presence utility and used in stake show
  • Adds e2e for set-id, get-id, sign commands

thewhaleking
thewhaleking previously approved these changes Sep 19, 2024
bittensor_cli/cli.py Outdated Show resolved Hide resolved
@ibraheem-opentensor ibraheem-opentensor merged commit f71ce24 into main Sep 19, 2024
2 of 3 checks passed
thewhaleking added a commit that referenced this pull request Sep 19, 2024
* Second set of Typer docstrings

* Third set of Typer docstrings (#94)

* Third set of Typer docstrings

* Fix into third set

* Removes newdoc.md

---------

Co-authored-by: ibraheem-opentensor <[email protected]>

* E2E tests + fixes (#92)

* Fixes help text

* Adds set and get id tests

* Adds flags for wallet_sign and improves prompt

* Adds wallet set-id, get-id, sign tests

* Fixes stake show command edge cases

* Removes accidental readme file

* Removes explicit email flag

* Decode CHK SS58 (#95)

* Fix child hotkeys by decoding the ss58

* Race condition

* Fixes stake show command edge cases

* Removes accidental readme file

* WIP

* Made call_add_proposal work

* Adds proposal list call

* Fixed dict vs class change.

---------

Co-authored-by: Watchmaker <[email protected]>
Co-authored-by: Benjamin Himes <[email protected]>
Co-authored-by: Benjamin Himes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants