Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding getTotalColdkeyStakeand getTotalHotkeyStake to the staking precompile #1159

Open
wants to merge 9 commits into
base: devnet-ready
Choose a base branch
from
Open

Adding getTotalColdkeyStakeand getTotalHotkeyStake to the staking precompile #1159

wants to merge 9 commits into from
+115 −6

Conversation

Shr1ftyy
Copy link

@Shr1ftyy Shr1ftyy commented Jan 15, 2025 •
edited
Loading

Description

Adds a getTotalColdkeyStake and getTotalHotkeyStake to the staking precompile

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Shr1ftyy Shr1ftyy marked this pull request as ready for review January 20, 2025 06:00
@Shr1ftyy Shr1ftyy requested a review from unconst as a code owner January 20, 2025 06:00
@Shr1ftyy Shr1ftyy changed the title Adding a getStakeColdkey method to the staking precompile Adding a getTotalColdkeyStake, and getTotalHotkeyStake method to the staking precompile Jan 21, 2025
@Shr1ftyy Shr1ftyy changed the title Adding a getTotalColdkeyStake, and getTotalHotkeyStake method to the staking precompile Adding getTotalColdkeyStakeand getTotalHotkeyStake to the staking precompile Jan 21, 2025
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 21, 2025
@Shr1ftyy
feat: modify total stake coldkey func
3de9c3d 
- gets stake for coldkey on subnet and across all subnets
open-junius
open-junius reviewed Jan 27, 2025
View reviewed changes
pallets/subtensor/src/staking/stake_utils.rs Outdated
/// This function returns the cumulative stake across all subnets for the coldkey.
/// This value represents the sum of stakes from all subnets associated with this coldkey.
/// This function is useful for calculating the total stake for a coldkey across all subnets.
pub fn get_stake_for_coldkey(coldkey: &T::AccountId) -> u64 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/opentensor/subtensor/blob/devnet-ready/pallets/subtensor/src/staking/helpers.rs#L59
we can call it to get all stake for coldkey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@open-junius open-junius open-junius left review comments

@unconst unconst Awaiting requested review from unconst unconst is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shr1ftyy @open-junius @gztensor