Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bonds_penalty hyperparam #1160

Open
wants to merge 3 commits into
base: devnet-ready
Choose a base branch
from

Conversation

andreea-popescu-reef
Copy link
Contributor

Description

reviving #181

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

N/A

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

camfairchild
camfairchild previously approved these changes Jan 17, 2025
pallets/subtensor/src/epoch/math.rs Outdated Show resolved Hide resolved
pallets/subtensor/src/epoch/math.rs Outdated Show resolved Hide resolved
@camfairchild
Copy link
Contributor

Make sure to squash the clippy issues.
Otherwise LGTM, thanks for the contribution!

camfairchild
camfairchild previously approved these changes Jan 19, 2025
@camfairchild camfairchild added the no-spec-version-bump PR does not contain changes that requires bumping the spec version label Jan 19, 2025
@camfairchild camfairchild added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants