Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic fee pallet #1220

Open
wants to merge 1 commit into
base: devnet-ready
Choose a base branch
from
Open

Conversation

ales-otf
Copy link
Contributor

@ales-otf ales-otf commented Jan 31, 2025

Description

Currently we have dynamic fee pallet and associated inherent data provider in our node. As we use base fee for fee calculations, the dynamic fee pallet and its inherent data are rudiments of the frontier's template. The dynamic fee pallet also introduces a small overhead by performing inherent transaction every block. This PR removes pallet dynamic fee from the runtime and associated inherent data from the node.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@ales-otf ales-otf changed the base branch from main to devnet-ready January 31, 2025 17:23
@ales-otf ales-otf added skip-cargo-audit This PR fails cargo audit but needs to be merged anyway and removed skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Jan 31, 2025
@ales-otf ales-otf force-pushed the fix/remove-dynamic-fee branch from f182532 to 8cd99e7 Compare January 31, 2025 17:29
@ales-otf ales-otf marked this pull request as ready for review January 31, 2025 21:03
@ales-otf ales-otf requested a review from unconst as a code owner January 31, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants