Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] fix socat version to 1.7.4.4 #2706

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Irving-cl
Copy link
Contributor

This PR changes the installation of socat from using 'apt' to manual installation.

We found the latest socat version 1.8.0.3 has an issue when running with OTBR docker. To avoid the error caused by version and facilitate local development, the PR provides a script to install socat of version 1.7.4.4 and replaces the installation in CI and scripts..

BTW, the installation in install_openthread_binraries is unnecessary because install_common_dependencies will be done anyway.

@Irving-cl Irving-cl requested review from bukepo and superwhd February 11, 2025 11:46
@Irving-cl Irving-cl force-pushed the fix_socat_version branch 2 times, most recently from e7a87d8 to aa37528 Compare February 11, 2025 11:52
@Irving-cl Irving-cl marked this pull request as draft February 11, 2025 11:55
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.29%. Comparing base (2b41187) to head (c8dede4).
Report is 942 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2706       +/-   ##
===========================================
- Coverage   55.77%   43.29%   -12.49%     
===========================================
  Files          87      108       +21     
  Lines        6890    13400     +6510     
  Branches        0      963      +963     
===========================================
+ Hits         3843     5801     +1958     
- Misses       3047     7291     +4244     
- Partials        0      308      +308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant