Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radio] add mInfo.mTxInfo.mMaxCsmaBackoffs support #965

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

zhanglongxia
Copy link
Contributor

The current radio driver doesn't handle the mInfo.mTxInfo.mMaxCsmaBackoffs field of the tx frame. The maximum number of CSMA-CA backoffs is set to the fixed value 4.

This commit sets the maximum number of CSMA-CA backoffs to mInfo.mTxInfo.mMaxCsmaBackoffs.

@zhanglongxia zhanglongxia added the enhancement New feature or request label Jan 3, 2025
@zhanglongxia zhanglongxia requested review from LuDuda and jwhui January 3, 2025 08:33
@zhanglongxia zhanglongxia force-pushed the nrf-max-csma-backoffs branch from 96d5521 to 2e45d79 Compare January 6, 2025 08:27
Current radio driver doesn't process the 'mInfo.mTxInfo.mMaxCsmaBackoffs'
field of the tx frame. The maximum number of CSMA-CA backoffs is set to
the fixed value 4.

This commit sets the maximum number of CSMA-CA backoffs to
`mInfo.mTxInfo.mMaxCsmaBackoffs`.
@zhanglongxia zhanglongxia force-pushed the nrf-max-csma-backoffs branch from 2e45d79 to d1cad96 Compare January 6, 2025 08:32
@zhanglongxia zhanglongxia requested a review from bukepo January 6, 2025 10:04
@bukepo
Copy link
Member

bukepo commented Jan 7, 2025

@LuDuda are you still maintaining this project? It looks like third_party/NordicSemiconductor is still based on a version 4 years ago.

@LuDuda
Copy link
Member

LuDuda commented Jan 10, 2025

@bukepo as is described here, ot-nrf528xx is in the maintenance mode and based on legacy SDK. For all new products the official solution is based on nRF Connect SDK.

New functionalities are added only to the NCS-based solution; however, I am still fine with making fixes within this project.

Copy link
Member

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jwhui jwhui changed the title [radio] add 'mInfo.mTxInfo.mMaxCsmaBackoffs' support [radio] add mInfo.mTxInfo.mMaxCsmaBackoffs support Jan 13, 2025
@jwhui jwhui merged commit 0216e0d into openthread:main Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants