Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modify css variables #1051

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

xuanlid
Copy link
Contributor

@xuanlid xuanlid commented Jan 17, 2025

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

base和common变量修改,和设计师已对齐

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Updated color palette across base and common theme variables
    • Refined color shades for gray, red, green, blue, and indigo tones
    • Adjusted text, background, border, and icon color variables
    • Enhanced visual consistency and potentially improved accessibility

Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

Walkthrough

This pull request introduces comprehensive updates to the color palette in the theme's base and common Less files. The changes involve redefining CSS custom properties across various color ranges, including gray, red, green, blue, and indigo. The modifications adjust color variables for different UI elements, updating shades and introducing new values to enhance visual consistency and improve the overall design language of the application.

Changes

File Changes
packages/theme/base/src/base.less - Updated gray variables (e.g., --te-base-gray-60 to --te-base-gray-130)
- Modified red color variables (e.g., --te-base-red-110 changes)
- Adjusted green color variables (e.g., --te-base-green-70 changes)
- Significant changes to blue (e.g., --te-base-blue-20 updates) and indigo color variables (e.g., --te-base-indigo-30 changes)
packages/theme/base/src/common.less - Updated color information variables (e.g., --te-common-color-info changes)
- Modified text color properties (e.g., --te-common-text-primary updates)
- Adjusted link, icon, and border colors (e.g., --te-common-text-link changes)
- Changed background color variables for primary and secondary elements (e.g., --te-common-bg-primary updates)

Possibly related PRs

Suggested labels

ready_for_review

Suggested reviewers

  • hexqi
  • chilingling

Poem

🎨 A Rabbit's Color Tale 🐰

Hues dancing, shades so bright,
Variables shifting left and right,
Gray to blue, red to green,
A palette refresh, now pristine!
Code colors sing their merry song! 🌈


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 156a8c0 and 57ff475.

📒 Files selected for processing (1)
  • packages/theme/base/src/common.less (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/theme/base/src/common.less
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: push-check

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added bug Something isn't working refactor-main refactor/develop branch feature labels Jan 17, 2025
@xuanlid xuanlid changed the title fix: Modify css variables f尔奥托、: Modify css variables Jan 17, 2025
@xuanlid xuanlid changed the title f尔奥托、: Modify css variables feat: Modify css variables Jan 17, 2025
@github-actions github-actions bot added enhancement New feature or request and removed bug Something isn't working labels Jan 17, 2025
@hexqi hexqi merged commit 4e4b18e into opentiny:refactor/develop Jan 20, 2025
5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jan 27, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor-main refactor/develop branch feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants