fix: data source type select and display exception

[SonyLeo]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

新建数据源：设置数据源类型为 树结构 时， 显示为 对象数组

Issue Number: N/A

What is the new behavior?

新建数据源：正常设置和显示数据源类型

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Refactor
  • Simplified data source type selection component
  • Streamlined state management for radio button options
  • Improved component structure and data binding

[coderabbitai]

Walkthrough

The pull request modifies the DataSourceType.vue component, focusing on simplifying its state management and template rendering. The changes involve replacing a reactive state object with a constant array for radio button options, introducing a new ref variable for data source type, and removing unnecessary methods. The implementation now directly binds radio button selections and uses a watch function to handle changes, resulting in a more streamlined and maintainable component structure.

Changes

File	Change Summary
packages/plugins/datasource/src/DataSourceType.vue	- Replaced reactive state with ref and constant RADIO_GROUP - Simplified state management - Removed handleChange and selectDataType methods - Updated imports from reactive/watchEffect to ref/watch

Suggested labels

ready_for_review

Suggested reviewers

• hexqi

Poem

🐰 Refactoring dance, state so light
Radio buttons now shine bright
Complexity fades, code takes flight
With ref and watch, pure delight!
A rabbit's code, clean and tight 🎉

Possibly related PRs

• fix: datasource remote result could not reshow again after edit #847: Changes in DataSourceRemoteDataResult.vue involving similar state management simplification and handleChange method restructuring

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/plugins/datasource/src/DataSourceType.vue (1)

38-47: Consider extracting RADIO_GROUP as a shared constant.

While the implementation is correct, consider moving RADIO_GROUP outside the component for better reusability if these options are used elsewhere in the application.

+ // constants.js
+ export const DATA_SOURCE_TYPES = [
+   {
+     name: '对象数组',
+     value: 'array'
+   },
+   {
+     name: '树结构',
+     value: 'tree'
+   }
+ ]

  // DataSourceType.vue
- const RADIO_GROUP = [...]
+ import { DATA_SOURCE_TYPES } from './constants'
+ const RADIO_GROUP = DATA_SOURCE_TYPES

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5789c5 and f575757.

📒 Files selected for processing (1)

• packages/plugins/datasource/src/DataSourceType.vue (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: push-check

🔇 Additional comments (3)

packages/plugins/datasource/src/DataSourceType.vue (3)

5-8: Clean and idiomatic Vue template implementation!

The template changes follow Vue best practices with proper v-model binding and v-for iteration. The radio group implementation is both maintainable and accessible.

---

16-16: Appropriate use of Vue composition API imports!

The switch to watch and ref from reactive and watchEffect simplifies the state management approach.

---

49-56: Clean state management implementation!

The use of ref and watch provides a simple and effective way to manage the component's state and emit updates. The implementation correctly fixes the data source type selection issue mentioned in the PR objectives.