fix: modify button padding

[James-9696]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Enhanced visual presentation and interaction states for various UI components including buttons, dropdowns, input fields, and modals.

• Style

  • Adjusted padding, margin, and color properties across multiple components for improved layout consistency and user feedback.

[coderabbitai]

Walkthrough

The changes involve modifications to the styling of various UI components within the component-common.less file. Adjustments include alterations to padding, margins, and color properties for components such as buttons, dropdowns, input fields, and modals, aimed at enhancing visual presentation and interaction feedback.

Changes

File Path

Change Summary

packages/theme/base/src/component-common.less

- Increased padding for .tiny-button.tiny-button from 0 8px to 0 12px. - Refined styles for .tiny-select-dropdown, including margins and padding adjustments. - Added hover and focus states for .tiny-input.tiny-input border colors. - Adjusted padding and margin for .tiny-collapse.tiny-collapse. - Updated hover effects and padding for .tiny-tree.tiny-tree. - Modified active and hover styles for .tiny-tabs.tiny-tabs. - Adjusted padding and margin for .tiny-dialog-box.tiny-dialog-box. - Updated padding and border-radius for .tiny-modal__box.tiny-modal__box. - Enhanced styles for .tiny-notify.tiny-notify for better visual distinction. - Updated background and text colors for .tiny-tooltip.tiny-tooltip.

Possibly related PRs

• feat(theme): component style && common theme #814: This PR modifies CSS styling within the ConfigItem.vue and MetaCodeEditor.vue components, which may relate to the overall theme and component styling changes in the main PR.
• fix: improve the style priority of overwriting tinyvue #848: This PR involves changes to the class definitions in component-common.less, which directly relates to the modifications made in the same file in the main PR.
• fix(theme): modify collapse-item border #851: This PR includes updates to the .tiny-collapse-item and .tiny-button classes in component-common.less, which are also addressed in the main PR's changes to the collapse and button components.

Suggested labels

refactoring, ready_for_review, refactor-main

Suggested reviewers

• chilingling
• hexqi

🐰 In the meadow, colors bright,
Buttons and tabs now feel just right.
With margins snug and paddings fair,
Our UI shines with tender care.
Hopping through styles, a joyful sight! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d158fcd and 6a46085.

📒 Files selected for processing (1)

• packages/theme/base/src/component-common.less (1 hunks)

🔇 Additional comments (3)

packages/theme/base/src/component-common.less (3)

277-279: LGTM: Button padding adjustment improves usability.

The increased horizontal padding (0 12px) provides better touch targets while maintaining the compact height, which aligns with common button design patterns.

---

Line range hint 324-361: Ensure consistent padding in button groups.

The button group styles should maintain the same padding as individual buttons (0 12px) to ensure visual consistency across the UI.

Let's verify the usage of button groups in the codebase:

Consider adding explicit padding to button group items:

 .tiny-button-group.tiny-button-group {
   ul.tiny-group-item {
     border-radius: var(--te-base-border-radius-normal);
     li {
+      padding: 0 12px;
       background-color: var(--te-common-bg-container);

---

277-277: Consider using spacing variables for padding.

Instead of hard-coding pixel values, consider using design system spacing variables for better maintainability and consistency.

-  padding: 0 12px;
+  padding: 0 var(--te-base-spacing-3);  // Assuming this variable exists

Let's check if spacing variables are defined:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.