pin node version for docusaurus build #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ollevche <[email protected]>
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
abstractionfactory
approved these changes
Nov 19, 2024
ollevche
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: ollevche <[email protected]>
ollevche
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: ollevche <[email protected]>
This was referenced Nov 20, 2024
ollevche
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: ollevche <[email protected]>
ollevche
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: ollevche <[email protected]>
ollevche
added a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: ollevche <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The website build started to fail with a weird error (
Unexpected end of JSON input), see this run as an example. We don't pin node version in website Dockerfile build so it seems to be broken due to node v23 upgrade. Some of the tools don't work well with node v23 yet (including Docusaurus) so this PR sets node version to v22.Related Docusaurus issue: facebook/docusaurus#10684
Target Release
1.9.0
Checklist
Website/documentation checklist