Self host redoc #284
Open
Self host redoc #284
+2,056
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zanda256
force-pushed
the
38/self-host-redoc
branch
from
19d35cd to
55b5300
Compare
abstractionfactory
requested changes
Feb 6, 2025
abstractionfactory
requested changes
Feb 7, 2025
Signed-off-by: Sekiranda <[email protected]>
Signed-off-by: Sekiranda <[email protected]>
Signed-off-by: Sekiranda <[email protected]>
Zanda256
force-pushed
the
38/self-host-redoc
branch
from
42a1597 to
af3e612
Compare
abstractionfactory
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Hey @Zanda256 looking good! Let's add the SHA256 checksum explicitly to the pull tool as a command line argument and we'll record it the first time we download it in the go:generate command.
| @@ -44,5 +46,10 @@ func (w writer) Write(ctx context.Context) error { | |||
| if err := w.storage.WriteFile(ctx, "index.html", indexHTML); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| if err := w.storage.WriteFile(ctx, "redoc.standalone.js", reDocScriptFile); err != nil { | |||
There was a problem hiding this comment.
Please also write record.standalone.js.LICENSE.txt here.
| } | ||
|
|
||
| // Pull ReDoc LICENSE file | ||
| licenseFileURL := "https://raw.githubusercontent.com/Redocly/redoc/refs/heads/main/LICENSE" |
There was a problem hiding this comment.
This should pull from https://cdn.redoc.ly/redoc/VERSION/bundles/redoc.standalone.js.LICENSE.txt, not from the Git repo as it may change over versions.
Signed-off-by: Sekiranda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we download and host the latest Redoc script every time we generate a backend.
Resolves #38
Checklist