Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing shellcheck #1135

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fixing shellcheck #1135

merged 1 commit into from
Oct 14, 2024

Conversation

abstractionfactory
Copy link
Contributor

No description provided.

@abstractionfactory
Fixing shellcheck
f9d1384 
Signed-off-by: AbstractionFactory <[email protected]>
@ollevche
Copy link
Member

ollevche commented Oct 14, 2024 •
edited
Loading

Do we also want to skip validation if there is no response on optional fields?

#1118 (comment)

@abstractionfactory
Copy link
Contributor Author

@ollevche this is a check for the shell scripts.

@abstractionfactory abstractionfactory merged commit c0109fa into main Oct 14, 2024
2 checks passed
@abstractionfactory abstractionfactory deleted the bugfix-shellcheck branch October 14, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollevche ollevche ollevche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abstractionfactory @ollevche