feat: validate gpg key against existing list of providers #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diogenes Fernandes <[email protected]>
diofeher
changed the title
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
|
Thanks @diofeher I'm out for the weekend, I'll review first thing on Monday! |
Signed-off-by: Diogenes Fernandes <[email protected]>
diofeher
force-pushed
the
validate-opentofu-keys
branch
from
23175ab to
ed6662e
Compare
|
Thanks @abstractionfactory, enjoy your weekend! |
abstractionfactory
requested changes
Jan 13, 2025
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
abstractionfactory
approved these changes
Jan 16, 2025
cam72cam
reviewed
Jan 16, 2025
ollevche
reviewed
Jan 21, 2025
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
cam72cam
reviewed
Jan 27, 2025
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
Signed-off-by: Diogenes Fernandes <[email protected]>
|
Moving back to draft since the PR in libregistry isn't merged yet. We will review this PR fully once the libregistry one is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356
Depends on opentofu/libregistry#47
Code based on @cam72cam's work
Description
This code is used to verify if the provided key by the user is really signing the packages they meant to be signing. There were multiple instances when the user provided wrong keys and then commits had to be reverted in order to provide the right signing key.
Failing signature:
Working signature:
