-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create registry dev environment #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cube2222
reviewed
Dec 8, 2023
Evi1Pumpkin
force-pushed
the
create-registry-dev-environment
branch
3 times, most recently
from
December 11, 2023 07:15
1b83661
to
ba36763
Compare
… cron Signed-off-by: Ronny Orot <[email protected]>
Signed-off-by: Ronny Orot <[email protected]>
Signed-off-by: Ronny Orot <[email protected]>
Signed-off-by: Ronny Orot <[email protected]>
Signed-off-by: Ronny Orot <[email protected]>
Signed-off-by: Ronny Orot <[email protected]>
Evi1Pumpkin
force-pushed
the
create-registry-dev-environment
branch
from
December 11, 2023 16:44
ba36763
to
332e27d
Compare
Signed-off-by: Ronny Orot <[email protected]>
ghost
reviewed
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the codebase enough to approve or request changes, but it seems to me that the upload would still happen to the same bucket. From what I read, this is not the intention? (Also, added some nitpicks.) Nevermind, I completely misread the code.
Signed-off-by: Ronny Orot <[email protected]>
Evi1Pumpkin
force-pushed
the
create-registry-dev-environment
branch
from
December 12, 2023 15:22
ad1bdd6
to
bd0e4cb
Compare
…te-registry-dev-environment
Signed-off-by: Ronny Orot <[email protected]>
RLRabinowitz
approved these changes
Dec 13, 2023
Signed-off-by: Ronny Orot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to create a dev environment for our registry, for easy development without impacting production.
The idea
<original-branch-name>-bump-versions-<unix-timestamp>
. So we won't make the branch dirty with unwanted changes.Changes
bump-and-publish-versions-prod.yml
.bump-versions.yml
andgenerate-and-deploy.yml
can now be triggered as sub-workflows (bybump-and-publish-versions-prod.yml
), or dispatched from the actions screen for development porpuses.bump-versions.yml
andgenerate-and-deploy.yml
get theenvironment
setting as an input.bump-versions.yml
was triggered with thedevelopment
env, it'll push the changes to a new branch.How to use the registry dev environment
I created a branch with changes and want to run it targeting the dev registry. The branch is called
Evi1Pumpkin-patch-1
.Bump Provider and Module Versions
workflow, and run it using my new branch:Evi1Pumpkin-patch-1-bump-versions-1702366742
. I can get it from thePrint Branch
step. If you have a better idea on how to make it more user-friendly I would love to hear.Fixes #64