Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-6810: Add support for E2EE #259

Merged
merged 5 commits into from
Jun 8, 2023
Merged

DEVX-6810: Add support for E2EE #259

merged 5 commits into from
Jun 8, 2023

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Feb 20, 2023

Description

This PR does the following:

  • Updates the Opentok#create_session method to:

    • Add an option for :e2ee to valid_opts
    • Adds conditional checks to the method ensure :e2ee is not set to true if :media_mode is :relayed or if :archive_mode is :always
    • Update the docs comments to provide information on the new param and a link to the relevant OpenTok documentation
  • Adds unit tests for the new functionality described above

Motivation and Context

It implements a feature in the SDK which is being added to the API.

How Has This Been Tested?

Added a number tests for calling Opentok#create_session with the new :e2ee param set, as well as tests for invalid configuration options

Example Output or Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rev the version to 4.6.0 in the version.rb file? And note changes in the CHANGES.md file?

lib/opentok/opentok.rb Show resolved Hide resolved
@superchilled superchilled marked this pull request as ready for review March 6, 2023 11:07
@superchilled superchilled requested a review from jeffswartz March 6, 2023 11:07
lib/opentok/opentok.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a commit to rev the minor version.

@superchilled superchilled merged commit 17bbfaf into dev Jun 8, 2023
@superchilled superchilled deleted the devx-6810-e2ee-support branch June 8, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants