CI: Enable ASAN testing #9537
Merged
CI: Enable ASAN testing #9537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosefe
reviewed
Dec 7, 2023
yosefe
reviewed
Dec 8, 2023
ivankochin
commented
Dec 11, 2023
yosefe
reviewed
Dec 11, 2023
yosefe
previously approved these changes
Dec 12, 2023
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
iyastreb
approved these changes
Dec 20, 2023
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
yosefe
previously approved these changes
Dec 28, 2023
ivankochin
force-pushed
the
build/enable-asan-ci-testing
branch
from
adc3370 to
70ffe65
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
ivankochin
commented
Jan 4, 2024
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
yosefe
reviewed
Jan 7, 2024
buildlib/pr/main.yml
Outdated
| @@ -170,7 +170,7 @@ resources: | |||
| options: $(DOCKER_OPT_ARGS) $(DOCKER_OPT_VOLUMES) | |||
| - container: ubuntu22_cuda12 | |||
| image: rdmz-harbor.rdmz.labs.mlnx/ucx/x86_64/ubuntu22.04-mofed5-cuda12:3 | |||
| options: $(DOCKER_OPT_ARGS) $(DOCKER_OPT_VOLUMES) $(DOCKER_OPT_GPU) | |||
| options: $(DOCKER_OPT_ARGS) --net=host $(DOCKER_OPT_VOLUMES) $(DOCKER_OPT_GPU) | |||
There was a problem hiding this comment.
AFAIK out dockers should already run with "--net host" by using a wrapper script
Right, @Alexey-Rivkin @artemry-nv ?
There was a problem hiding this comment.
We have 2 Docker containers with the "host" network mode:
centos7_ib
centos7_cuda11
https://github.com/openucx/ucx/blob/master/buildlib/pr/main.yml#L12-L17
Others default to the "bridge" network mode.
There was a problem hiding this comment.
@Alexey-Rivkin thanks. Basically, all dockers that run gtest should be with "--net host". I guess most dockers are build only.
Can we add "--net host" to DOCKER_OPT_IB?
yosefe
previously approved these changes
Jan 8, 2024
ivankochin
force-pushed
the
build/enable-asan-ci-testing
branch
from
582c42b to
6756bb8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
brminich
reviewed
Jan 8, 2024
contrib/test_jenkins.sh
Outdated
Comment on lines
1120
to
1123
| # build for devel tests and gtest | ||
| build devel --enable-gtest --enable-asan --without-valgrind | ||
|
|
||
| # all are running gtest |
There was a problem hiding this comment.
minor: comments are not really informative here (copy-past)? I'd remove
brminich
previously approved these changes
Jan 9, 2024
yosefe
approved these changes
Jan 11, 2024
ivankochin
force-pushed
the
build/enable-asan-ci-testing
branch
from
2832b28 to
f3441f4
Compare
yosefe
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add Address Sanitizer check job to CI