Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vexctl add subcommand #111

Merged
merged 2 commits into from
Sep 13, 2023
Merged

vexctl add subcommand #111

merged 2 commits into from
Sep 13, 2023

Conversation

puerco
Copy link
Member

@puerco puerco commented Aug 18, 2023

This PR creates a new vexctl add subcommand. This new subcommand lets users add new vex statements to an existing document. This frees them from having to deal with updating dates, etc.

vex add will output the updated document to STDOUT or optionally can write to a new file or edit documents in place.

Note: Before merging needs #110 and a rebase

Signed-off-by: Adolfo García Veytia (Puerco) [email protected]

@puerco puerco requested a review from luhring August 18, 2023 03:41
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some lints issues, but otherwise lgtm

go.mod Outdated Show resolved Hide resolved
@puerco puerco force-pushed the add-command branch 2 times, most recently from c002152 to ef582ab Compare September 5, 2023 17:41
@puerco
Copy link
Member Author

puerco commented Sep 5, 2023

This should be ready as the prereqs are merged. @luhring @cpanato ptal.

internal/cmd/add.go Outdated Show resolved Hide resolved
This commit introduces a new `vexctl`add subcommand that lets users
add new statements to existing openvex documents.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@puerco puerco added the enhancement New feature or request label Sep 13, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thank you

@cpanato cpanato merged commit 2d5c2b1 into openvex:main Sep 13, 2023
@puerco puerco deleted the add-command branch September 13, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants