show subcommand creation for review #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandt Keller <[email protected]>
brandtkeller
force-pushed
the
show_command
branch
from
4fa17dd to
6d05f85
Compare
|
Hey @brandtkeller thanks for fixing this one 🙏 I do think that it adds value! Having the reference handy is one of those quality of life improvements that you don't notice until it is there. I have one small ask, can you please rename the subcommand to There is another PR incoming to make |
Signed-off-by: Brandt Keller <[email protected]>
|
@puerco That makes a lot of sense to me. Thanks for adding context towards intended subcommands. Updated to |
puerco
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
Intent here is really a lightweight example to drive discussion.
Deciding if this improves the UX for consumers of the project and provides value, and if so - then discussing format and other supporting documentation.
The bug that this originates from had indicated that there may be some value in this command. If that is no longer the case then we can close out this PR and the Bug all together!