Restore attestation capability after repo split #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhring
approved these changes
Jan 17, 2023
puerco
force-pushed
the
attest
branch
2 times, most recently
from
5f562ae to
5ce8348
Compare
|
Fixed the boileplate check by dropping the spdx tag change. I will do that in the future. |
This commit introduces the attestation package which wraps the openvex attestation module and adds signing and attaching capabilities. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Attestation signing and attaching was removed in openvex/go-vex#3 so we now implement that functionality local in vexctl. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This comit adds a ToJSON method to the vexctl attestation that intercepts the call to the /vex equivalent to output any signed data instead of the plain attestation. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
We now sign when generating the attestation, this allows us to get the signed json without attaching. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Since signing and attaching now defaults to false, we add shorthand flags as they will be typed a lot more. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to openvex/go-vex#3 this PR restores (and improves a little bit) the attesting functionality in
vexctl. A small change is that signed attestations can now be output to stdout (not just attached to images).There are a couple of open questions about data handling while moving subjects from vex to intoto, but will be handled once the attestaing spec is ready. The way attestaing works now is equivalent to the attester in the old repo.