Add setuptools
as a requirement (via pkg_resources
)
#1168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for this project! I've had it on my radar for a while but didn't have a use case for it. let me know if I need to make any changes.
Description
setuptools
as a base requirmentUsually, this comes with
pip
, but it's possible to have a virtual environment without pip installed. In my case, I'm usingpdm
, which does not includepip
in it's virtual environments.At
setuptools==41.0.0
, we getAttributeError: module 'collections' has no attribute 'MutableMapping'
, as it expectscolllections.abc.MutableMapping
.You can reproduce it by creating a new project with
pdm
and addinganomalib
.This is actually a dependency for
pytorch-lightening
. But since it's restricted to>=1.7.0,<1.10.0
I figured we need to add the fix here.Changes
Checklist