Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools as a requirement (via pkg_resources) #1168

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

murilo-cunha
Copy link
Contributor

@murilo-cunha murilo-cunha commented Jul 6, 2023

Thanks a lot for this project! I've had it on my radar for a while but didn't have a use case for it. let me know if I need to make any changes.

Description

  • Include setuptools as a base requirment

Usually, this comes with pip, but it's possible to have a virtual environment without pip installed. In my case, I'm using pdm, which does not include pip in it's virtual environments.

At setuptools==41.0.0, we get AttributeError: module 'collections' has no attribute 'MutableMapping', as it expects colllections.abc.MutableMapping.

You can reproduce it by creating a new project with pdm and adding anomalib.

This is actually a dependency for pytorch-lightening. But since it's restricted to >=1.7.0,<1.10.0 I figured we need to add the fix here.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

Usually, this comes with `pip`, but it's possible to have a virtual environment without pip installed.
@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Jul 6, 2023
@ashwinvaidya17 ashwinvaidya17 merged commit a56121d into openvinotoolkit:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants