Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot-fix wrong requirement for setup.py #1823

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Hot-fix wrong requirement for setup.py #1823

merged 1 commit into from
Mar 6, 2024

Conversation

harimkang
Copy link
Contributor

@harimkang harimkang commented Mar 6, 2024

πŸ“ Description

  • Provide a clear summary of the changes and the issue that has been addressed.
  • πŸ› οΈ Fixes # (issue number)

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Kang, Harim <[email protected]>
@github-actions github-actions bot added the Setup label Mar 6, 2024
@harimkang harimkang marked this pull request as ready for review March 6, 2024 08:23
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is what I tried

pip install .
anomalib install
anomalib fit --model Padim --data MVTec

With this option everything works with correct torch version

pytorch-lightning==2.2.1
torch==2.1.2+cu118
torchmetrics==0.10.3
torchvision==0.16.2+cu118

pip install .[full]
anomalib fit --model Padim --data MVTec

With this option torch installation is incorrect but re-installing the right version works

pytorch-lightning==2.2.1
torch==2.1.2
torchmetrics==0.10.3
torchvision==0.16.2

Basically there is no CUDA here

@samet-akcay samet-akcay merged commit 34b3a90 into openvinotoolkit:main Mar 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants