Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸš€ Add Auto-Encoder based FRE #2025

Merged
merged 24 commits into from
May 20, 2024
Merged

Conversation

nahuja-intel
Copy link
Contributor

πŸ“ Description

  • Added lightning and torch models for FRE along with config file.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some leftover here to be updated from DFM to FRE

configs/model/fre.yaml Outdated Show resolved Hide resolved
configs/model/fre.yaml Outdated Show resolved Hide resolved
src/anomalib/models/image/fre/lightning_model.py Outdated Show resolved Hide resolved
src/anomalib/models/image/fre/lightning_model.py Outdated Show resolved Hide resolved
src/anomalib/models/image/fre/lightning_model.py Outdated Show resolved Hide resolved
src/anomalib/models/image/fre/torch_model.py Outdated Show resolved Hide resolved
@samet-akcay samet-akcay changed the title Initial commit for Auto-Encoder based FRE πŸš€ Add Auto-Encoder based FRE Apr 29, 2024
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I only have minor comments

src/anomalib/models/image/fre/torch_model.py Outdated Show resolved Hide resolved
src/anomalib/models/image/fre/torch_model.py Outdated Show resolved Hide resolved
src/anomalib/models/image/fre/torch_model.py Outdated Show resolved Hide resolved
src/anomalib/models/image/fre/lightning_model.py Outdated Show resolved Hide resolved
src/anomalib/models/image/fre/lightning_model.py Outdated Show resolved Hide resolved
configs/model/fre.yaml Outdated Show resolved Hide resolved
configs/model/fre.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort

@samet-akcay samet-akcay enabled auto-merge (squash) May 20, 2024 14:05
@samet-akcay samet-akcay merged commit 14ab566 into openvinotoolkit:main May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants