-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀from_config API: Create a path between API & configuration file (CLI) #2065
Merged
ashwinvaidya17
merged 7 commits into
openvinotoolkit:main
from
harimkang:harimkan/new-from-config
May 24, 2024
Merged
🚀from_config API: Create a path between API & configuration file (CLI) #2065
ashwinvaidya17
merged 7 commits into
openvinotoolkit:main
from
harimkang:harimkan/new-from-config
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kang, Harim <[email protected]>
Signed-off-by: Kang, Harim <[email protected]>
Signed-off-by: Kang, Harim <[email protected]>
harimkang
commented
May 17, 2024
…to harimkan/new-from-config
Signed-off-by: Kang, Harim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts! I have a few minor comments. But we can also look into refactoring these later on.
ashwinvaidya17
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
#1992
from_config
,the ability to create model and datamodule instances via the Configuration file.How to test:
Get full configuration file (output from cli - TBD or Use
--print_config > configs.yaml
)(anomalib) anomalib fit --model anomalib.models.Padim --data anomalib.data.MVTec --print_config > anomalib_config.yaml
Use Configuration file with API
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.