-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting: Enable PLR6301
, # could be a function, class method or static method
#2288
Linting: Enable PLR6301
, # could be a function, class method or static method
#2288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts! I have a few questions.
What happens if instead of ignoring the rule, we convert methods like configure_transforms
, on_train_start
(and other lightning methods), forward
, and backward
to static?
Signed-off-by: Samet Akcay <[email protected]>
Signed-off-by: Samet Akcay <[email protected]>
Signed-off-by: Samet Akcay <[email protected]>
Signed-off-by: Samet Akcay <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2288 +/- ##
==========================================
+ Coverage 80.85% 80.91% +0.05%
==========================================
Files 247 247
Lines 10834 10886 +52
==========================================
+ Hits 8760 8808 +48
- Misses 2074 2078 +4 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts! Let's merge this
π Description
PLR6301
, # could be a function, class method or static method⨠Changes
Select what type of change your PR is:
β Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.