Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new torch metrics #235

Closed
wants to merge 4 commits into from
Closed

Conversation

ashwinvaidya17
Copy link
Collaborator

Description

  • Change F1 to F1Score
  • Fixes F1 score issue with torchmetrics>=0.6.1

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay added Metrics Metric Component. Refactor Refactoring is needed labels Apr 17, 2022
@djdameln
Copy link
Contributor

This will cause conflicts with #230. Maybe it would be better to change F1 -> F1Score in that PR

@ashwinvaidya17
Copy link
Collaborator Author

This will cause conflicts with #230. Maybe it would be better to change F1 -> F1Score in that PR

In that case should I close this or rebase and target to #230 ?

@djdameln
Copy link
Contributor

In that case should I close this or rebase and target to #230 ?

Actually most of the lines that are changed in this PR are removed in my PR, because we no longer hard code the F1 metric. You could close this one and I'll take care of it in #230.

@ashwinvaidya17 ashwinvaidya17 deleted the fix/av/torchmetrics branch June 13, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metrics Metric Component. Refactor Refactoring is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants