Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue with cPython<=3.11.3 #2416

Merged

Conversation

Kogia-sima
Copy link
Contributor

📝 Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@Kogia-sima Kogia-sima requested a review from djdameln as a code owner November 12, 2024 14:05
@samet-akcay
Copy link
Contributor

Thanks @Kogia-sima for the PR!

@ashwinvaidya17, do we always need to filter the data?

@ashwinvaidya17
Copy link
Collaborator

I just tried this on Python 3.10.14 and it works fine. Maybe it is an unintended bug in 3.11.3. Personally, I would be hesitant on rolling back security changes.

@ashwinvaidya17
Copy link
Collaborator

@ashwinvaidya17
Copy link
Collaborator

Maybe I am being paranoid, but this was the original reason it was introduced https://vorakl.com/articles/tar-curdir/

@adrianboguszewski
Copy link
Contributor

@ashwinvaidya17
Copy link
Collaborator

@adrianboguszewski alright let's remove filter for now

@samet-akcay samet-akcay enabled auto-merge January 20, 2025 14:52
@samet-akcay samet-akcay disabled auto-merge January 20, 2025 18:31
@samet-akcay samet-akcay merged commit caf342c into openvinotoolkit:main Jan 20, 2025
10 checks passed
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.51%. Comparing base (084331d) to head (587a900).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/anomalib/data/utils/download.py 75.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (084331d) and HEAD (587a900). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (084331d) HEAD (587a900)
1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2416       +/-   ##
===========================================
- Coverage   78.94%   64.51%   -14.44%     
===========================================
  Files         311      311               
  Lines       13197    13201        +4     
===========================================
- Hits        10419     8516     -1903     
- Misses       2778     4685     +1907     
Flag Coverage Δ
integration_py3.10 64.51% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Anomalib does not work with Python<=3.11.3
4 participants