-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility issue with cPython<=3.11.3 #2416
Fix compatibility issue with cPython<=3.11.3 #2416
Conversation
Thanks @Kogia-sima for the PR! @ashwinvaidya17, do we always need to filter the data? |
I just tried this on |
Even 3.9.20 has these changes |
Maybe I am being paranoid, but this was the original reason it was introduced https://vorakl.com/articles/tar-curdir/ |
@ashwinvaidya17 it doesn't work with python 3.10 on our CI: https://github.com/openvinotoolkit/openvino_build_deploy/actions/runs/12833122680/job/35787421755?pr=168 |
@adrianboguszewski alright let's remove filter for now |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
===========================================
- Coverage 78.94% 64.51% -14.44%
===========================================
Files 311 311
Lines 13197 13201 +4
===========================================
- Hits 10419 8516 -1903
- Misses 2778 4685 +1907
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
📝 Description
filter
arguments ofTarfile.extract()
method, which was introduced during CPython 3.11.4 release ([Bug]: Anomalib does not work with Python<=3.11.3 #2393 (comment)).✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.