-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Add Multi-GPU Training Support #2435
🚀 Add Multi-GPU Training Support #2435
Conversation
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
@@ -600,17 +600,18 @@ def validate_gt_mask(mask: torch.Tensor | None) -> Mask | None: | |||
if mask is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to revisit the docstrings for this method
Signed-off-by: Ashwin Vaidya <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/v2 #2435 +/- ##
=============================================
Coverage ? 78.38%
=============================================
Files ? 302
Lines ? 12940
Branches ? 0
=============================================
Hits ? 10143
Misses ? 2797
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, thanks 🔥
Signed-off-by: Ashwin Vaidya <[email protected]>
Signed-off-by: Ashwin Vaidya <[email protected]>
Awesome, these are great news, thanks a lot! |
Our plan is to pre-release before the 20th |
Hello, we are so much looking forward to multi-GPU training :) |
Hi, as soon as passing this CI :) We didn't release it on the 20th of December mainly because we thought the documentation is not sufficient. We worked on the documentation during Christmas. @blaz-r kindly added a new algorithm to v2 as well, but one of the tests are failing now. As soon as we fix the test, we'll release, which we hope to sort out by the end of today. |
Awesome, thanks! |
I think I found the issue, I'm going to open a PR in a few mins. Apologies about that. |
no worries @blaz-r, I think I've fixed it already, let's wait for the test results |
Good @samet-akcay, that might fix it, but in case it doesn't I also opened a PR that also adds |
Looks like it is passing |
Great! 😄 |
@samet-akcay Heyho, just wanted to ask for the current status of multi-GPU training? |
You could try it with |
Thanks, that is great news - I will give it a try 👍 |
@samet-akcay I tried to get beta 2 up and running, however, I am not sure how to update our workflow. |
📝 Description
Testing script
Works
Not Working
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.