Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCO merge group workflow configuration #2528

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

ashwinvaidya17
Copy link
Collaborator

πŸ“ Description

  • We need this workflow because due to current limitation by DCO it does not run on merge groups

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Ashwin Vaidya <[email protected]>
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 79.11%. Comparing base (084331d) to head (2cca9b0).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2528      +/-   ##
==========================================
+ Coverage   78.94%   79.11%   +0.16%     
==========================================
  Files         311      311              
  Lines       13197    13201       +4     
==========================================
+ Hits        10419    10444      +25     
+ Misses       2778     2757      -21     
Flag Coverage Ξ”
integration_py3.10 64.51% <ΓΈ> (?)
unit_py3.10 64.72% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@samet-akcay
Copy link
Contributor

does this have to be a standalone workflow, or can we add this to one of our checks like pr.yaml?

@ashwinvaidya17 ashwinvaidya17 merged commit 3e64f09 into main Jan 21, 2025
14 checks passed
@ashwinvaidya17 ashwinvaidya17 deleted the ashwin/fix_dco_merge_group branch January 21, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants