Mediapipe packet latency metric #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstrzele
force-pushed
the
mp_request_latency_metric
branch
4 times, most recently
from
edc16b3 to
5d94518
Compare
bstrzele
requested review from
dtrawins and
dkalinowski
and removed request for
dtrawins
bstrzele
force-pushed
the
mp_request_latency_metric
branch
from
a510f77 to
7f17873
Compare
dkalinowski
reviewed
Feb 10, 2025
src/llm/http_llm_calculator.cc
Outdated
| @@ -266,7 +266,8 @@ class HttpLLMCalculator : public CalculatorBase { | |||
| } catch (...) { | |||
| return absl::InvalidArgumentError("Response generation failed"); | |||
| } | |||
| timestamp = timestamp.NextAllowedInStream(); | |||
| auto now = std::chrono::system_clock::now(); | |||
| timestamp = ::mediapipe::Timestamp(std::chrono::duration_cast<std::chrono::microseconds>(now.time_since_epoch()).count()); | |||
There was a problem hiding this comment.
the name is unfortunate here
Suggested change
| timestamp = ::mediapipe::Timestamp(std::chrono::duration_cast<std::chrono::microseconds>(now.time_since_epoch()).count()); | |
| iterationBeginTimestamp = ::mediapipe::Timestamp(std::chrono::duration_cast<std::chrono::microseconds>(now.time_since_epoch()).count()); |
dkalinowski
reviewed
Feb 10, 2025
bstrzele
force-pushed
the
mp_request_latency_metric
branch
from
4dfe6bc to
3694653
Compare
dkalinowski
approved these changes
Feb 11, 2025
|
Do we expect a demo? Or old demos to be reworked? @bstrzele |
There is one demo work in progress for both graph processing time and this one |
bstrzele
force-pushed
the
mp_request_latency_metric
branch
5 times, most recently
from
ef43bc6 to
df10202
Compare
dtrawins
approved these changes
Feb 18, 2025
bstrzele
force-pushed
the
mp_request_latency_metric
branch
from
df10202 to
626fb8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``