-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing TODOs 2025.1 #3051
Addressing TODOs 2025.1 #3051
Conversation
src/filesystem.hpp
Outdated
@@ -28,6 +28,7 @@ | |||
#include "model_version_policy.hpp" | |||
#include "openssl/md5.h" | |||
#include "status.hpp" | |||
#include "stringutils.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move implementations & include to cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -181,7 +181,6 @@ TEST_F(StressPipelineConfigChanges, KFSAddNewVersionDuringPredictLoad) { | |||
requiredLoadResults, | |||
allowedLoadResults); | |||
} | |||
// TODO: Disabled because we cannot start http server multiple times https://github.com/drogonframework/drogon/issues/2210 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave comment why disabled but without TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
src/test/modelmanager_test.cpp
Outdated
@@ -1382,11 +1383,7 @@ TEST_F(ModelManager, HandlingInvalidLastVersion) { | |||
status = manager.getModelInstance(modelDirectory.name, 3, modelInstance3, modelInstanceUnloadGuard); | |||
modelInstanceUnloadGuard.reset(); | |||
ASSERT_EQ(status, ovms::StatusCode::MODEL_VERSION_NOT_LOADED_YET); | |||
|
|||
#ifdef _WIN32 | |||
// FIXME: TODO: Manual unload required because OVCORE keeps the file handle opened after modelLoad, preventing the test to remove the directory. | |||
modelInstance2->unloadModelComponents(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unloadModelComponents need to be deleted also - this was not part of the test oryginally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
🛠 Summary
CVS-161784
🧪 Checklist