Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing TODOs 2025.1 #3051

Merged
merged 10 commits into from
Feb 11, 2025
Merged

Addressing TODOs 2025.1 #3051

merged 10 commits into from
Feb 11, 2025

Conversation

dkalinowski
Copy link
Collaborator

@dkalinowski dkalinowski commented Feb 11, 2025

🛠 Summary

CVS-161784

🧪 Checklist

  • Change follows security best practices.

@dkalinowski dkalinowski mentioned this pull request Feb 11, 2025
3 tasks
@@ -28,6 +28,7 @@
#include "model_version_policy.hpp"
#include "openssl/md5.h"
#include "status.hpp"
#include "stringutils.hpp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move implementations & include to cpp

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -181,7 +181,6 @@ TEST_F(StressPipelineConfigChanges, KFSAddNewVersionDuringPredictLoad) {
requiredLoadResults,
allowedLoadResults);
}
// TODO: Disabled because we cannot start http server multiple times https://github.com/drogonframework/drogon/issues/2210
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave comment why disabled but without TODO?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -1382,11 +1383,7 @@ TEST_F(ModelManager, HandlingInvalidLastVersion) {
status = manager.getModelInstance(modelDirectory.name, 3, modelInstance3, modelInstanceUnloadGuard);
modelInstanceUnloadGuard.reset();
ASSERT_EQ(status, ovms::StatusCode::MODEL_VERSION_NOT_LOADED_YET);

#ifdef _WIN32
// FIXME: TODO: Manual unload required because OVCORE keeps the file handle opened after modelLoad, preventing the test to remove the directory.
modelInstance2->unloadModelComponents();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unloadModelComponents need to be deleted also - this was not part of the test oryginally.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dkalinowski dkalinowski merged commit f16ebdd into main Feb 11, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants