Streaming test for windows #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkalinowski
force-pushed
the
streaming-test-99
branch
from
9a441ff to
1929ffd
Compare
atobiszei
reviewed
Feb 11, 2025
src/test/streaming_test.cpp
Outdated
| #ifdef _WIN32 | ||
| GTEST_SKIP() << "Test disabled on windows"; | ||
| #endif | ||
| // #ifdef _WIN32 |
src/test/streaming_test.cpp
Outdated
| #ifdef _WIN32 | ||
| GTEST_SKIP() << "Test disabled on windows"; | ||
| #endif | ||
| // #ifdef _WIN32 |
src/test/streaming_test.cpp
Outdated
| GTEST_SKIP() << "Test disabled on windows"; | ||
| #endif | ||
| // #ifdef _WIN32 | ||
| // GTEST_SKIP() << "Test disabled on windows"; |
src/test/streaming_test.cpp
Outdated
| #ifdef _WIN32 | ||
| GTEST_SKIP() << "Test disabled on windows"; | ||
| #endif | ||
| // #ifdef _WIN32 |
There was a problem hiding this comment.
remove in all other places as well
src/test/streaming_test.cpp
Outdated
| static auto DisconnectWhenNotified(std::mutex& mtx) { | ||
| return [&mtx](::inference::ModelInferRequest* req) { | ||
| std::lock_guard<std::mutex> lock(mtx); // waits for lock to be released | ||
| static auto DisconnectWhenNotified_(std::future<void>& fut) { |
There was a problem hiding this comment.
Why _ suffix was added?
src/test/streaming_test.cpp
Outdated
| @@ -14,7 +14,8 @@ | |||
| // limitations under the License. | |||
| //***************************************************************************** | |||
| #include <chrono> | |||
| #include <mutex> | |||
| #include <future> | |||
| #include <mutex> // ? | |||
dkalinowski
force-pushed
the
streaming-test-99
branch
from
3c14327 to
09b311d
Compare
atobiszei
approved these changes
Feb 11, 2025
bstrzele
approved these changes
Feb 12, 2025
bstrzele
approved these changes
Feb 12, 2025
mzegla
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Changed wait mechanism from mutex to futures, it turns out there was double lock in the same thread in tests
CVS-157750
🧪 Checklist