enabled unit test MetricFlowTest.GrpcPredict #3057
Open
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasapala
approved these changes
Feb 12, 2025
atobiszei
reviewed
Feb 12, 2025
| @@ -197,7 +197,7 @@ class MetricFlowTest : public TestWithTempDir { | |||
|
|
|||
| void SetUp() override { | |||
| TestWithTempDir::SetUp(); | |||
| char* n_argv[] = {(char*)"ovms", (char*)"--config_path", (char*)"/unused", (char*)"--rest_port", (char*)"8080"}; // Workaround to have rest_port parsed in order to enable metrics | |||
| char* n_argv[] = {(char*)"ovms", (char*)"--config_path", (char*)"/unused", (char*)"--rest_port", (char*)"8080", (char*)"--grpc_max_threads", (char*)"4"}; // Workaround to have rest_port parsed in order to enable metrics | |||
| @@ -274,7 +271,7 @@ TEST_F(MetricFlowTest, GrpcPredict) { | |||
| EXPECT_THAT(server.collect(), HasSubstr(METRIC_NAME_STREAMS + std::string{"{name=\""} + modelName + std::string{"\",version=\"1\"} "} + std::to_string(4))); | |||
| EXPECT_THAT(server.collect(), Not(HasSubstr(METRIC_NAME_STREAMS + std::string{"{name=\""} + dagName + std::string{"\",version=\"1\"} "}))); | |||
|
|
|||
| EXPECT_THAT(server.collect(), HasSubstr(METRIC_NAME_INFER_REQ_QUEUE_SIZE + std::string{"{name=\""} + modelName + std::string{"\",version=\"1\"} "} + std::to_string(2))); | |||
| EXPECT_THAT(server.collect(), HasSubstr(METRIC_NAME_INFER_REQ_QUEUE_SIZE + std::string{"{name=\""} + modelName + std::string{"\",version=\"1\"} "} + std::to_string(6))); | |||
There was a problem hiding this comment.
Why this change (2->6)? This test worked fine on Linux and we need change the value on Windows?
dkalinowski
reviewed
Feb 12, 2025
| @@ -197,7 +197,7 @@ class MetricFlowTest : public TestWithTempDir { | |||
|
|
|||
| void SetUp() override { | |||
| TestWithTempDir::SetUp(); | |||
| char* n_argv[] = {(char*)"ovms", (char*)"--config_path", (char*)"/unused", (char*)"--rest_port", (char*)"8080"}; // Workaround to have rest_port parsed in order to enable metrics | |||
| char* n_argv[] = {(char*)"ovms", (char*)"--config_path", (char*)"/unused", (char*)"--rest_port", (char*)"8080", (char*)"--grpc_max_threads", (char*)"4"}; // Workaround to have rest_port parsed in order to enable metrics | |||
There was a problem hiding this comment.
adding new arguments but arg_count remains unchanged, i dont think this param is effective in this unit test
atobiszei
approved these changes
Feb 20, 2025
atobiszei
approved these changes
Feb 20, 2025
atobiszei
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-161484
Avoid sporadic unit tests failures on windows
🧪 Checklist
``