Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/requirements-*.txt: bump all versions #296

Merged
merged 1 commit into from
Aug 14, 2019
Merged

ci/requirements-*.txt: bump all versions #296

merged 1 commit into from
Aug 14, 2019

Conversation

IRDonch
Copy link

@IRDonch IRDonch commented Aug 13, 2019

Except for numpy in requirements-ac.txt, which needs to stay at 1.16 due to an issue with Pylint.

EDIT: Bumped numpy too.

@eaidova
Copy link
Collaborator

eaidova commented Aug 13, 2019

Except for numpy in requirements-ac.txt, which needs to stay at 1.16 due to an issue with Pylint

Pylint issue: pylint-dev/pylint#2865
looks like it was fixed in the last pylint version, but I need additional check,

UPD: yes, it works with:
pylint 2.3.1
astroid 2.2.5
numpy 1.17.0

@IRDonch
Copy link
Author

IRDonch commented Aug 13, 2019

looks like it was fixed in the last pylint version, but I need additional check

Oh, that's great to know. Let me know if you confirm it.

@eaidova
Copy link
Collaborator

eaidova commented Aug 13, 2019

@IRDonch , pylint 2.3.1(+ astroid 2.2.5) successfuly works with numpy 1.16.1 and higher.
But it detects one new issue, which I fix in #294

@IRDonch
Copy link
Author

IRDonch commented Aug 13, 2019

Alright, in that case I'll bump NumPy too after #294 is merged.

@eaidova
Copy link
Collaborator

eaidova commented Aug 14, 2019

@IRDonch , another requirement which can not be bumped is py-cpuinfo==4.0.0 (the next release has the bug with showing CPU flags from frozen code, it is not fixed yet). But we use this lib only for cpu_extension loading. As I know, CPU extension is going to be a part of CPU plugin in R3, so probably it makes sense to remove this lib from accuracy checker dependency at all.

@IRDonch
Copy link
Author

IRDonch commented Aug 14, 2019

another requirement which can not be bumped is py-cpuinfo==4.0.0

Good thing I didn't bump it then, right? :-)

(I use pip-compile to build these files, so I automatically obey all requirements set by setup.py.)

@IRDonch IRDonch marked this pull request as ready for review August 14, 2019 09:54
@IRDonch
Copy link
Author

IRDonch commented Aug 14, 2019

Jenkins please retry a build

@IRDonch IRDonch requested review from eaidova and zmaslova August 14, 2019 10:36
@IRDonch IRDonch merged commit 69f37a2 into openvinotoolkit:develop Aug 14, 2019
@IRDonch IRDonch deleted the bump-requirements branch August 14, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants